From f22817082463370bb4fadd57b638a6b1cfbd7e63 Mon Sep 17 00:00:00 2001 From: Mike Greiling Date: Fri, 15 Sep 2017 15:41:57 -0500 Subject: [PATCH] update documentation with note about chrome --- README.md | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index b17f004..d7e3dee 100644 --- a/README.md +++ b/README.md @@ -49,8 +49,9 @@ options are: 2. `git` 3. `chrome` 4. `node` -5. `phantomjs` -6. `postgres` +5. `yarn` +6. `phantomjs` +7. `postgres` ### Adding a new build @@ -59,3 +60,14 @@ the name would be `ruby-2.4-golang-1.9-git-2.14`. 1. Add a test task: `ruby-2.4-golang-1.9-git-2.14 test: *test_custom` 1. Add a new build task: `ruby-2.4-golang-1.9-git-2.14: *build_and_deploy_custom` + +# Note regarding Google Chrome + +Google has a policy of yanking older versions of Google Chrome from their PPA whenever a new major +version is released. This means images with non-current chrome versions will fail to build. Until +a better solution is worked out, we will remove images based on older Chrome versions from the build +process, but preserve them for reference within a comment in the `.gitlab-ci.yml` file. + +These images will persist in the docker repository for legacy use, but will no longer be recompiled. +If an update ever needs to be made to an image containing an older version of Chrome, a workaround +can be modeled after https://gitlab.com/gitlab-org/gitlab-build-images/merge_requests/54