NcamGnrvngu/gitlab-build-images
1
0
Fork 0
mirror of https://ops.gitlab.net/gitlab-org/gitlab-build-images.git synced 2025-12-09 10:02:56 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

update documentation with note about chrome

Browse source
This commit is contained in:
Mike Greiling 2017-09-15 15:41:57 -05:00
parent 5f43f91c5a
commit f228170824
1 changed files with 14 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

16
README.md
View file

@ -49,8 +49,9 @@ options are:
2. `git`
3. `chrome`
4. `node`
5. `phantomjs`
6. `postgres`
5. `yarn`
6. `phantomjs`
7. `postgres`
### Adding a new build
@ -59,3 +60,14 @@ the name would be `ruby-2.4-golang-1.9-git-2.14`.
1. Add a test task: `ruby-2.4-golang-1.9-git-2.14 test: *test_custom`
1. Add a new build task: `ruby-2.4-golang-1.9-git-2.14: *build_and_deploy_custom`
# Note regarding Google Chrome
Google has a policy of yanking older versions of Google Chrome from their PPA whenever a new major
version is released. This means images with non-current chrome versions will fail to build. Until
a better solution is worked out, we will remove images based on older Chrome versions from the build
process, but preserve them for reference within a comment in the `.gitlab-ci.yml` file.
These images will persist in the docker repository for legacy use, but will no longer be recompiled.
If an update ever needs to be made to an image containing an older version of Chrome, a workaround
can be modeled after https://gitlab.com/gitlab-org/gitlab-build-images/merge_requests/54