NcamGnrvngu/gitlab-build-images
1
0
Fork 0
mirror of https://ops.gitlab.net/gitlab-org/gitlab-build-images.git synced 2025-12-09 18:12:55 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge branch 'sh-bump-chrome-driver' into 'master'

Browse source 
Bump ChromeDriver to 2.35 to support Chrome 64

See merge request gitlab-org/gitlab-build-images!81
This commit is contained in:
Stan Hu 2018-02-27 00:32:34 +00:00
commit b418a1afab
2 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
scripts/custom-docker-build
View file

@ -25,6 +25,9 @@ function print_golang_args() {
printf -- "--build-arg GOLANG_DOWNLOAD_SHA256=%s " "$GOLANG_DOWNLOAD_SHA256"
}
# If you add a new minor version here, be sure to check that the
# ChromeDriver supports this: https://sites.google.com/a/chromium.org/chromedriver/downloads
# You may need to bump the version in scripts/install-chrome.
function print_chrome_args() {
case "$1" in
60|60.0) CHROME_VERSION=60.0.3112.90-1 ;;

2
scripts/install-chrome
View file

@ -14,6 +14,6 @@ env DEBIAN_FRONTEND="noninteractive" apt-get install -y google-chrome-stable=$CH
rm -rf /var/lib/apt/lists/*
# Install ChromeDriver
wget -q https://chromedriver.storage.googleapis.com/2.33/chromedriver_linux64.zip
wget -q https://chromedriver.storage.googleapis.com/2.35/chromedriver_linux64.zip
unzip chromedriver_linux64.zip -d /usr/local/bin
rm -f chromedriver_linux64.zip