From fc4604725f562b4a714ceea2dfb1885f02e29d34 Mon Sep 17 00:00:00 2001 From: Stan Hu Date: Mon, 26 Feb 2018 16:15:22 -0800 Subject: [PATCH 1/2] Bump ChromeDriver to 2.35 to support Chrome 64 --- scripts/install-chrome | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/install-chrome b/scripts/install-chrome index 044a6c1..fc5309c 100755 --- a/scripts/install-chrome +++ b/scripts/install-chrome @@ -14,6 +14,6 @@ env DEBIAN_FRONTEND="noninteractive" apt-get install -y google-chrome-stable=$CH rm -rf /var/lib/apt/lists/* # Install ChromeDriver -wget -q https://chromedriver.storage.googleapis.com/2.33/chromedriver_linux64.zip +wget -q https://chromedriver.storage.googleapis.com/2.35/chromedriver_linux64.zip unzip chromedriver_linux64.zip -d /usr/local/bin rm -f chromedriver_linux64.zip From 3feee1e8fd75d839aac6a4f792de5b836b1f7d71 Mon Sep 17 00:00:00 2001 From: Stan Hu Date: Mon, 26 Feb 2018 16:17:15 -0800 Subject: [PATCH 2/2] Add a comment about updating ChromeDriver --- scripts/custom-docker-build | 3 +++ 1 file changed, 3 insertions(+) diff --git a/scripts/custom-docker-build b/scripts/custom-docker-build index 756239e..d8cdff6 100755 --- a/scripts/custom-docker-build +++ b/scripts/custom-docker-build @@ -25,6 +25,9 @@ function print_golang_args() { printf -- "--build-arg GOLANG_DOWNLOAD_SHA256=%s " "$GOLANG_DOWNLOAD_SHA256" } +# If you add a new minor version here, be sure to check that the +# ChromeDriver supports this: https://sites.google.com/a/chromium.org/chromedriver/downloads +# You may need to bump the version in scripts/install-chrome. function print_chrome_args() { case "$1" in 60|60.0) CHROME_VERSION=60.0.3112.90-1 ;;