From 96da23a8fd77bc7aafcbc659725b08608cd7f988 Mon Sep 17 00:00:00 2001 From: Lukas Eipert Date: Mon, 1 Oct 2018 14:19:20 +0200 Subject: [PATCH] Remove references to deleted phantom script Phantom JS has not been used since December 2017, so I think it is save to remove the reference. For reference: d5c225c14888516128ee29bf4a97564ff41143aa --- Dockerfile.custom | 4 ---- README.md | 5 ++--- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/Dockerfile.custom b/Dockerfile.custom index f2cc10e..d3a3df2 100644 --- a/Dockerfile.custom +++ b/Dockerfile.custom @@ -24,10 +24,6 @@ ARG CHROME_VERSION ARG CHROME_DRIVER_VERSION RUN if [ -n "$CHROME_VERSION" ]; then /scripts/install-chrome $CHROME_VERSION $CHROME_DRIVER_VERSION && google-chrome --version; fi -# PhantomJS -ARG PHANTOMJS_VERSION -RUN if [ -n "$PHANTOMJS_VERSION" ] ; then /scripts/install-phantomjs $PHANTOMJS_VERSION; fi - # NodeJS and Yarn ARG NODE_INSTALL_VERSION ARG YARN_INSTALL_VERSION diff --git a/README.md b/README.md index b24d3c5..3448cbd 100644 --- a/README.md +++ b/README.md @@ -35,9 +35,9 @@ The name is defined as `[feature]-[version]` pairs, separated by `-`. Here are some example build names: -1. `ruby-2.1-git-2.7-phantomjs-2.1` +1. `ruby-2.1-git-2.7` 1. `ruby-2.3.3-golang-1.8-git-2.7-chrome-60.0-node-7.1-postgresql-9.6` -1. `ruby-2.4.1-golang-1.8-git-2.7-phantomjs-2.1-node-7.1-postgresql-9.6` +1. `ruby-2.4.1-golang-1.8-git-2.7-node-7.1-postgresql-9.6` The first pair represents the base image and version. So `ruby-2.1-...` will use the `ruby:2.1` base image, while `golang-1.8` will use the `golang:1.8` base image. @@ -50,7 +50,6 @@ options are: 1. `chrome` 1. `node` 1. `yarn` -1. `phantomjs` 1. `postgres` 1. `terraform` 1. `ansible`