NcamGnrvngu/gitlab-build-images
1
0
Fork 0
mirror of https://ops.gitlab.net/gitlab-org/gitlab-build-images.git synced 2025-12-09 18:12:55 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge branch 'vs/drop-old-nodejs' into 'master'

Browse source 
Drop unsupported Node.js versions

See merge request https://gitlab.com/gitlab-org/gitlab-build-images/-/merge_requests/724

Merged-by: Lukas 'Eipi' Eipert <leipert@gitlab.com>
Approved-by: Lukas 'Eipi' Eipert <leipert@gitlab.com>
Co-authored-by: Vitaly Slobodin <vslobodin@gitlab.com>
This commit is contained in:
Lukas 'Eipi' Eipert 2023-09-19 09:52:05 +00:00
commit 1907e97f9f
3 changed files with 3 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

2
.gitlab/ci/cng-images.yml
View file

@ -3,7 +3,7 @@
variables:
LFS: '2.9'
CHROME: '109'
NODE: '16.14'
NODE: '18.17'
YARN: '1.22'
GRAPHICSMAGICK: '1.3.36'
POSTGRESQL: '11'

2
Dockerfile.danger
View file

@ -6,7 +6,7 @@ MAINTAINER GitLab Quality Team
# eg. https://gitlab.com/gitlab-org/gitlab-foss/-/jobs/275286625
ENV LC_ALL "C.UTF-8"
ENV NODE_VERSION=16.14.2
ENV NODE_VERSION=18.17.1
ENV YARN_VERSION=1.22.17
ENV GITLAB_GEM_VERSION=4.18.0
ENV DANGER_GEM_VERSION=8.4.5

5
scripts/lib/custom-docker-build
View file

@ -150,10 +150,7 @@ function print_lfs_args() {
function print_node_args() {
case "$1" in
14.15) NODE_INSTALL_VERSION=14.15.4 ;;
14|14.16) NODE_INSTALL_VERSION=14.16.0 ;;
16|16.14) NODE_INSTALL_VERSION=16.14.2 ;;
18|18.17) NODE_INSTALL_VERSION=18.17.0 ;;
18|18.17) NODE_INSTALL_VERSION=18.17.1 ;;
*) fail "Unknown node version $1" ;;
esac
printf -- "--build-arg NODE_INSTALL_VERSION=%s " "$NODE_INSTALL_VERSION"